Skip to content

refactor: return undefined for nonexistent document locations - #16676

Merged
kgryte merged 8 commits into
stdlib-js:developfrom
gururaj1512:refactor-json-pointer/resolve
Nov 17, 2026
Merged

kgryte merged 8 commits into
stdlib-js:developfrom
gururaj1512:refactor-json-pointer/resolve

Conversation

@gururaj1512

Copy link
Copy Markdown
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • refactor: handle proper return values in utils/json-pointer/resolve

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • None

What carried over from the reference(s)?

  • None

What differed, or what did you have to work out yourself?

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used LLM for refactoring documentation and test but manually reviewed by me.


@stdlib-js/reviewers

@gururaj1512
gururaj1512 requested a review from a team November 17, 2026 17:33
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 17, 2026
@stdlib-bot

stdlib-bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/json-pointer/resolve $\\color{red}194/198$
$\\color{green}+0.60\\%$
$\\color{red}26/28$
$\\color{green}+4.46\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{red}194/198$
$\\color{green}+0.60\\%$

The above coverage report was generated for the changes in this PR.

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte

kgryte commented Nov 17, 2026

Copy link
Copy Markdown
Member

@gururaj1512 Once merged, you'll want to submit a follow-up PR addressing the CI test failure.

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 17, 2026
@kgryte kgryte changed the title refactor: handle proper return values in utils/json-pointer/resolve refactor: return undefined for nonexistent document locations Nov 17, 2026
@kgryte
kgryte merged commit 83652c1 into stdlib-js:develop Nov 17, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants